[FFmpeg-devel] [PATCH] arm: hevc_qpel: Fix the assembly to work with non-multiple of 8 widths

[Martin Storsjö]

On Wed, 25 Aug 2021, Martin Storsjö wrote:

> This unbreaks the fate-checkasm-hevc_pel test on arm targets.
>
> The assembly assumed that the width passed to the DSP functions is
> a multiple of 8, while the checkasm test used other widths too.
>
> This wasn't noticed before, because the hevc_pel checkasm tests
> (that were added in 9c513edb7999a35ddcc6e3a8d984a96c8fb492a3 in
> January) weren't run as part of fate until in
> b492cacffd36ad4cb251ba1f13ac398318ee639a in August.
>
> As this hasn't been an issue in practice with actual full decoding
> tests, it seems like the actual decoder doesn't call these functions
> with such widths. Therefore, we could alternatively fix the test
> to only test things that the real decoder does, and this modification
> could be reverted.
>
> Signed-off-by: Martin Storsjö <martin at martin.st>
> ---
> libavcodec/arm/hevcdsp_qpel_neon.S | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)

Pushed this one to unbreak fate now, although I guess it'd be nice to 
align the checkasm test with what the decoder actually does.

// Martin