[FFmpeg-devel] [PATCH] tests/fate: move TTML-in-MP4 tests from subtitles.mak to mov.mak

Jan Ekström jeebjp at gmail.com
Wed Aug 25 23:21:27 EEST 2021


On Wed, Aug 25, 2021 at 10:58 PM Martin Storsjö <martin at martin.st> wrote:
>
> On Wed, 25 Aug 2021, Jan Ekström wrote:
>
> > subtitles.mak utilizes a more strict comparator and - to be honest -
> > the tests feel more at home in this location.
> > ---
>
> LGTM, although your commit message forgets to point out the relevant
> effect of it - we're not just doing this for sorting things in the most
> matching bucket, but because those tests were broken on Windows. Please
> mention that and mention that it was due to fate-sub-% getting
> CMP=rawdiff.
>

Thanks, applied with a better explanation part as
d48232fb4cdb55b3add08cef89c222a60d0896a9 .

Jan


More information about the ffmpeg-devel mailing list