[FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

[Michael Niedermayer]

On Sun, Aug 22, 2021 at 01:35:26PM -0700, Chad Fraleigh wrote:
> On 8/22/2021 11:18 AM, Michael Niedermayer wrote:
> > On Sun, Aug 15, 2021 at 11:24:47AM +0200, Nicolas George wrote:
> > > Nicolas George (12021-08-08):
> > > > Here is a patch series for fateserver, to fix warnings and enable Perl's
> > > > taint checks, thus protecting against a whole class of security issues.
> > > 
> > > I would appreciate somebody looks at the code before I deploy it and we
> > > re-enable the server.
> > 
> > noone in the whole community cares about the server or everyone trusts you
> > to never make a mistake. At least when limited to people knowing perl and
> > having time.
> > 
> > seriously, if someone has time and knows perl, please look over this,
> > even if by the time you do, this has already been applied.
> > 
> > The sooner someone goes over this the sooner the fateserver is online
> > again
> 
> It mostly looks good (from a perl perspective).
> 
> Just 3 questionable items..

Thanks for the review!

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210822/1cdbc193/attachment.sig>