[FFmpeg-devel] [PATCH 02/23] avfilter/internal: Uninline ff_insert_(in|out)pad()

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Mon Aug 16 16:29:35 EEST 2021


Nicolas George:
> Andreas Rheinhardt (12021-08-12):
>> These functions are not hot at all and future commits will make them
>> bigger.
>>
>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
>> ---
>> I haven't found a caller that adds a pad somewhere else than the end
>> of the list, so the index parameter could be removed. Shall I do so
>> or is there a compelling reason to retain this functionality?
> 
> No objection. It would be easy to 
> 

Ok, I'll do it.

>>  libavfilter/avfilter.c | 32 +++++++++++++++++++++++++++++---
>>  libavfilter/internal.h | 32 ++------------------------------
>>  2 files changed, 31 insertions(+), 33 deletions(-)
>>
>> diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c
>> index f9d7226386..de7501c37b 100644
>> --- a/libavfilter/avfilter.c
>> +++ b/libavfilter/avfilter.c
>> @@ -101,9 +101,23 @@ void ff_command_queue_pop(AVFilterContext *filter)
>>      av_free(c);
>>  }
>>  
>> -int ff_insert_pad(unsigned idx, unsigned *count, size_t padidx_off,
>> -                   AVFilterPad **pads, AVFilterLink ***links,
>> -                   AVFilterPad *newpad)
> 
>> +/**
>> + * Insert a new pad.
>> + *
>> + * @param idx Insertion point. Pad is inserted at the end if this point
>> + *            is beyond the end of the list of pads.
>> + * @param count Pointer to the number of pads in the list
>> + * @param padidx_off Offset within an AVFilterLink structure to the element
>> + *                   to increment when inserting a new pad causes link
>> + *                   numbering to change
>> + * @param pads Pointer to the pointer to the beginning of the list of pads
>> + * @param links Pointer to the pointer to the beginning of the list of links
>> + * @param newpad The new pad to add. A copy is made when adding.
>> + * @return >= 0 in case of success, a negative AVERROR code on error
>> + */
> 
> The documentation should be in the header where the function is
> declared: this is where we would be looking for it.
> 
insert_pad() has been made static in this patch; it is not declared in
any header any more. Therefore I moved the documentation together with
the function.

>> +static int insert_pad(unsigned idx, unsigned *count, size_t padidx_off,
>> +                      AVFilterPad **pads, AVFilterLink ***links,
>> +                      AVFilterPad *newpad)

- Andreas


More information about the ffmpeg-devel mailing list