[FFmpeg-devel] [PATCH 03/23] avfilter/avfilter: Allow to free pads generically

Nicolas George george at nsup.org
Mon Aug 16 15:47:20 EEST 2021


Andreas Rheinhardt (12021-08-12):
> This can be enabled/disabled on a per-filter basis by setting
> the new internal flags FF_FILTER_FLAG_FREE_(IN|OUT)PADS.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> ---
> It would be possible to only free the names of non-static pads;
> it could then be used with the headphone and afir filters.
> But I don't think the additional complexity is worth it.

I agree on principle. But I think it would be cleaner to implement it
with a per-pad flag.

We could replace the needs_writable field by a flags field, with
NEEDS_WRITABLE as the first flag and FREE_NAME as a new flag.

That way, you do not need to distinguish input and output pads in the
surrounding code.

But since you already wrote the code, I will not insist if you prefer to
keep it as it is.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210816/50bd5fd8/attachment.sig>


More information about the ffmpeg-devel mailing list