[FFmpeg-devel] [PATCH] movenc: Get rid of frag_start

Martin Storsjö martin at martin.st
Thu Aug 12 23:29:01 EEST 2021


On Thu, 12 Aug 2021, Hu Weiwen wrote:

> "frag_start" is redundant, and every occurance can be replaced with 
> cluster[0].dts - start_dts

I think I can agree about this, so I think the patch should be fine, 
thanks for taking the time to study it in detail!

My own mental model of the code, having written it this way, is based 
around having this variable, but I guess I can adapt to this change too.

While the change is ok, can we defer pushing it a couple days, in case 
something comes up in my (or your) mind about something we forgot to think 
about?

// Martin



More information about the ffmpeg-devel mailing list