[FFmpeg-devel] [PATCH 0/3] libavformat/protocols.c: avio_enum_protocols(): Cleanup

Michael Witten mfwitten at gmail.com
Thu Aug 12 00:17:00 EEST 2021


| Michael Witten:
| 
|   > However, {2} is presented as a bunch of tiny little transformations
|   > that are intended to aid comprehension; they can be squashed into
|   > one commit as the maintainer sees fit (indeed, as shown below, the
|   > squashed diff is already quite comprehensible):
| 
| Nicholas George:
| 
|   > This is my my opinion, but better squash related changes: what matters
|   > is the final code, how readable it is.
|   > 
|   > Regards,
|   > Nicolas George

In my discussion with Lynn, I realized that I was using:

  for(

instead of:

  for (

If a squash is desired, then it would be easy enough for the committer to
to alter the patch that is embedded in the cover-letter, and thereby get
both a squash and a fix the missing space.

Otherwise, if more changes are necessary, I can make this improvement in
a followup series.

Sincerely,
Michael Witten


More information about the ffmpeg-devel mailing list