[FFmpeg-devel] [PATCH 2.b/3] libavformat/protocols.c: avio_enum_protocols(): Convert the 'goto' loop to a 'for(; ; )' block

Lynne dev at lynne.ee
Wed Aug 11 22:29:47 EEST 2021


11 Aug 2021, 21:00 by mfwitten at gmail.com:

> The indentation will be cleaned up in the next commit.
>
> ---
>  libavformat/protocols.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavformat/protocols.c b/libavformat/protocols.c
> index 032f07bf72..2aa302d08f 100644
> --- a/libavformat/protocols.c
> +++ b/libavformat/protocols.c
> @@ -95,7 +95,7 @@ const char *avio_enum_protocols(void **const opaque, const int output)
>  {
>  typedef const URLProtocol *const *Iterator;
>  Iterator p = *opaque ? (Iterator)(*opaque) + 1 : url_protocols;
> -iterate:
> +    for(;;) {
>  if (*p) {
>  if ((output && (*p)->url_write) || (!output && (*p)->url_read)) {
>  *opaque = (void *)p;
> @@ -105,7 +105,7 @@ iterate:
>  goto done;
>  }
>  ++p;
> -    goto iterate;
> +    }
>  
>  done:
>  *opaque = NULL;
>

while (1) please. Let's not add more for (;;) loops.


More information about the ffmpeg-devel mailing list