[FFmpeg-devel] [PATCH 3/3] avcodech/h264_picture: use ff_thread_replace_frame()

[Andreas Rheinhardt]

James Almer:
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
>  libavcodec/h264_picture.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/libavcodec/h264_picture.c b/libavcodec/h264_picture.c
> index ff30166b4d..109a8ff31d 100644
> --- a/libavcodec/h264_picture.c
> +++ b/libavcodec/h264_picture.c
> @@ -154,8 +154,7 @@ int ff_h264_replace_picture(H264Context *h, H264Picture *dst, const H264Picture
>      av_assert0(src->tf.f == src->f);
>  
>      dst->tf.f = dst->f;
> -    ff_thread_release_buffer(h->avctx, &dst->tf);
> -    ret = ff_thread_ref_frame(&dst->tf, &src->tf);
> +    ret = ff_thread_replace_frame(h->avctx, &dst->tf, &src->tf);
>      if (ret < 0)
>          goto fail;
>  
> 
Is there a reason that you only intend to use this here? Couldn't one
replace all occurrences of ff_thread_ref_frame() with this (and remove
ff_thread_ref_frame())?

- Andreas