[FFmpeg-devel] [PATCH 2/2] FATE: add tests for v360/ssim360 filters

Derek Buitenhuis derek.buitenhuis at gmail.com
Mon Aug 9 16:43:02 EEST 2021


On 8/9/2021 11:29 AM, Anton Khirnov wrote:
> diff --git a/libavfilter/Makefile b/libavfilter/Makefile
> index b0348ccfa3..27dd0c4b47 100644
> --- a/libavfilter/Makefile
> +++ b/libavfilter/Makefile
> @@ -559,7 +559,8 @@ SKIPHEADERS-$(CONFIG_VULKAN)                 += vulkan.h
>  
>  OBJS-$(CONFIG_LIBGLSLANG)                    += glslang.o
>  
> -TOOLS     = graph2dot
> +TOOLS     = graph2dot                                                   \
> +            spherical_compare

Is there a reason it needs a new tool rather than ffmpeg.c?

> +frame 0
> +lavfi.ssim360.Y=0.97
> +lavfi.ssim360.U=1.00
> +lavfi.ssim360.V=1.00
> +lavfi.ssim360.All=1.00
> +lavfi.ssim360.dB=25.19

Is it wise to do a non-fuzzy compare of floats?

- Derek


More information about the ffmpeg-devel mailing list