[FFmpeg-devel] [PATCH 06/10] lavu/slicethread: return ENOSYS rather than EINVAL in the dummy func
Andreas Rheinhardt
andreas.rheinhardt at outlook.com
Sun Aug 8 20:41:36 EEST 2021
Anton Khirnov:
> EINVAL is the wrong error code here, since the arguments passed to the
> function are valid. The error is that the function is not implemented in
> the build, which corresponds to ENOSYS.
> ---
> libavutil/slicethread.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavutil/slicethread.c b/libavutil/slicethread.c
> index f928a5cf00..867ce32238 100644
> --- a/libavutil/slicethread.c
> +++ b/libavutil/slicethread.c
> @@ -240,7 +240,7 @@ int avpriv_slicethread_create(AVSliceThread **pctx, void *priv,
> int nb_threads)
> {
> *pctx = NULL;
> - return AVERROR(EINVAL);
> + return AVERROR(ENOSYS);
> }
>
> void avpriv_slicethread_execute(AVSliceThread *ctx, int nb_jobs, int execute_main)
>
LGTM.
- Andreas
More information about the ffmpeg-devel
mailing list