[FFmpeg-devel] [PATCH] Nvenc: Adding support for chroma qp offset for h264_nvenc and hevc_nvenc

[Timo Rothenpieler]

On 03.08.2021 17:14, Ricardo Monteiro wrote:
> Hi Timo,
> 
>> I do wonder if that information isn't (also) available via metadata on
>> the incoming frames, so it could be inferred from those by default.
> 
> Are you talking about a transcoding scenario? Where you would load the parameters from the input bitstream? I'm not sure how useful this would be though.
> 
>> Other than that, this will need the usual header-version-guards so it
>> doesn't break compatiblity with older headers and hence older drivers.
> 
> I updated the patch (attached).

I wonder, wouldn't it make more sense to move setting these from the two 
codec specific functions to set_constqp()?
Or are they useful in any other RC mode?

You don't need to send a new patch for that, I can just move them there 
before applying.


Timo

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4494 bytes
Desc: S/MIME Cryptographic Signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210808/2ec7e096/attachment.bin>