[FFmpeg-devel] [PATCH 1/4] avfilter/asrc_flite: Don't define an object by accident

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Sun Aug 8 00:24:54 EEST 2021


Andreas Rheinhardt:
> The flite filter apparently only wanted to declare a struct,
> but mistakenly also defined an unused and zero-initialized element
> with external linkage.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> ---
> Would not have happened if one had actually defined a typedef.
> 
>  libavfilter/asrc_flite.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavfilter/asrc_flite.c b/libavfilter/asrc_flite.c
> index e3065cff79..1478cc07fa 100644
> --- a/libavfilter/asrc_flite.c
> +++ b/libavfilter/asrc_flite.c
> @@ -81,7 +81,7 @@ struct voice_entry {
>      void (*unregister_fn)(cst_voice *);
>      cst_voice *voice;
>      unsigned usage_count;
> -} voice_entry;
> +};
>  
>  #define MAKE_VOICE_STRUCTURE(voice_name) {             \
>      .name          =                      #voice_name, \
> 
Will apply this patchset tomorrow unless there are objections.

- Andreas


More information about the ffmpeg-devel mailing list