[FFmpeg-devel] [PATCH 1/3] Revert "fftools/ffmpeg_filter: fix the flags parsing for scaler"

Linjie Fu fulinjie at zju.edu.cn
Sat Aug 7 13:15:05 EEST 2021


From: Linjie Fu <linjie.justin.fu at gmail.com>

This reverts commit b3a0548a981db52911dd34d9de254c4fee0a8f79.

This breaks the usage of swscale options, scale_sws_opts should be passed
to auto-inserted scale-filters.

The auto-inserted scaler accepts sws_flags in filtergraph complex which
overrides the 'flags' option for vf_scale and dump it in verbose, however
simple filtergraph doesn't override. Hence we got different verbose logs
printed in vf_scale when we specify -sws_flags in cmdline. It's a matter
of log print rather than option parsing.

Signed-off-by: Linjie Fu <linjie.justin.fu at gmail.com>
---
 fftools/ffmpeg_filter.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c
index 49076f13ee..a90858655d 100644
--- a/fftools/ffmpeg_filter.c
+++ b/fftools/ffmpeg_filter.c
@@ -977,11 +977,7 @@ int configure_filtergraph(FilterGraph *fg)
         }
         if (strlen(args))
             args[strlen(args)-1] = 0;
-
-        if (!strncmp(args, "sws_flags=", 10)) {
-            // keep the 'flags=' part
-            fg->graph->scale_sws_opts = av_strdup(args+4);
-        }
+        fg->graph->scale_sws_opts = av_strdup(args);
 
         args[0] = 0;
         while ((e = av_dict_get(ost->swr_opts, "", e,
-- 
2.31.1



More information about the ffmpeg-devel mailing list