[FFmpeg-devel] [PATCH] mxf : allow using codecs RAWVIDEO and V210

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Wed Aug 4 19:03:00 EEST 2021


Tomas Härdin:
>> -static int64_t mxf_write_cdci_common(AVFormatContext *s, AVStream *st, const UID key)
>> +static int64_t mxf_write_generic_desc(AVFormatContext *s, AVStream *st, const UID key)
>>  {
>>      MXFStreamContext *sc = st->priv_data;
>>      AVIOContext *pb = s->pb;
>> @@ -1115,7 +1133,7 @@ static int64_t mxf_write_cdci_common(AVFormatContext *s, AVStream *st, const UID
>>      const MXFCodecUL *color_primaries_ul;
>>      const MXFCodecUL *color_trc_ul;
>>      const MXFCodecUL *color_space_ul;
>> -    int64_t pos = mxf_write_generic_desc(s, st, key);
>> +    int64_t pos = mxf_write_file_desc(s, st, key);
>>      uint8_t *side_data;
>>  
>>      color_primaries_ul = mxf_get_codec_ul_by_id(ff_mxf_color_primaries_uls, st->codecpar->color_primaries);
>> @@ -1131,6 +1149,8 @@ static int64_t mxf_write_cdci_common(AVFormatContext *s, AVStream *st, const UID
>>      if (!stored_width)
>>          stored_width = (st->codecpar->width+15)/16*16;
>>  
>> +    // TODO: V210 ==> Stored Width shall be a multiple of 48.
> 
> This needs to be fixed before this can be pushed. I don't want
> incorrect code in master.
> 

Furthermore, this patch needs lots of FATE updates (which need to be
checked for correctness).

- Andreas


More information about the ffmpeg-devel mailing list