[FFmpeg-devel] [PATCH v1] avfilter/vf_vpp_qsv: add scale mode option

[Xiang, Haihao]

On Wed, 2021-08-04 at 09:47 +0800, Linjie Fu wrote:
> Hi Andreas,On Wed, Aug 4, 2021 at 8:30 AM Andreas Rheinhardt <
> andreas.rheinhardt at outlook.com> wrote:
> 
> > Linjie Fu:
> > > On Wed, Mar 24, 2021 at 2:15 PM Wang, Fei W <fei.w.wang at intel.com>
> > 
> > wrote:
> > > 
> > > > On Mon, 2021-03-22 at 20:12 +0800, Linjie Fu wrote:
> > > > > On Wed, Feb 24, 2021 at 9:44 AM Fei Wang <fei.w.wang at intel.com>
> > > > > wrote:
> > > > > > 
> > > > > > The option allow user to set diffenent scaling mode from
> > > > > > auto/low-power/high-quality.
> > > > > > 
> > > > > > More details:
> > > > > > 
> > > > 
> > > > 
> > 
> > 
https://github.com/Intel-Media-SDK/MediaSDK/blob/master/doc/mediasdk-man.md#mfxExtVPPScaling
> > > > > > 
> > > > > > Signed-off-by: Fei Wang <fei.w.wang at intel.com>
> > > > > > ---
> > > > > >  libavfilter/vf_vpp_qsv.c | 25 +++++++++++++++++++++++--
> > > > > >  1 file changed, 23 insertions(+), 2 deletions(-)
> > > > > > 
> > > > > > diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c
> > > > > > index 5d57707455..effc459d3b 100644
> > > > > > --- a/libavfilter/vf_vpp_qsv.c
> > > > > > +++ b/libavfilter/vf_vpp_qsv.c
> > > > > > @@ -43,8 +43,9 @@
> > > > > > 
> > > > > >  /* number of video enhancement filters */
> > > > > >  #define ENH_FILTERS_COUNT (7)
> > 
> > You forgot to increment this number; see
> > https://ffmpeg.org/pipermail/ffmpeg-devel/2021-August/283004.html
> 
> 
> Thanks for the reminder, patch lgtm.

I have a similar patch in my patchset: clean-up QSV filters 
http://ffmpeg.org/pipermail/ffmpeg-devel/2021-July/282742.html, 

ENH_FILTERS_COUNT is defined to 8 in 
http://ffmpeg.org/pipermail/ffmpeg-devel/2021-July/282759.html. Could you please
merge Andreas's patch? If so, I may rebase my patchset against the latest FFmpeg

Thanks
Haihao