[FFmpeg-devel] [PATCH 1/6] avfilter/af_aderivative: Don't use audiobuf for only 1 sample, fix leak

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Mon Aug 2 00:47:14 EEST 2021


Paul B Mahol:
> This patch is too much intrusive to be acceptable.
> 
> Isn't there simpler solution?
> 
Intrusive? You call that intrusive?
Anyway, here is a way to make it even less intrusive: Use "type *prv =
&p[c]" and don't modify the inner loop at all (and don't update prev
after the loop). If one used "type *prv = ((type*)p) + c", one could
additionally avoid having to add the p0 variable.
But I actually dislike this one-sample pseudo-array and therefore
intentionally switched away from it.

- Andreas


More information about the ffmpeg-devel mailing list