[FFmpeg-devel] [PATCH 6/6] avfilter/vf_find_rect: Don't make frame writable unnecessarily

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Mon Aug 2 00:15:33 EEST 2021


AVFrame.metadata is always owned by its AVFrame, it is not shared
in the first place, so one does not need to make the frame writable
to modify it.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
---
 libavfilter/vf_find_rect.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libavfilter/vf_find_rect.c b/libavfilter/vf_find_rect.c
index 1a94655b6b..415d633579 100644
--- a/libavfilter/vf_find_rect.c
+++ b/libavfilter/vf_find_rect.c
@@ -225,8 +225,6 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in)
 
     snprintf(buf, sizeof(buf), "%f", best_score);
 
-    av_frame_make_writable(in);
-
     av_dict_set_int(&in->metadata, "lavfi.rect.w", foc->obj_frame->width, 0);
     av_dict_set_int(&in->metadata, "lavfi.rect.h", foc->obj_frame->height, 0);
     av_dict_set_int(&in->metadata, "lavfi.rect.x", best_x, 0);
-- 
2.30.2



More information about the ffmpeg-devel mailing list