[FFmpeg-devel] [PATCH 07/34] avcodec/dvenc: Avoid copying packet data

Michael Niedermayer michael at niedermayer.cc
Mon Apr 26 16:04:25 EEST 2021


On Mon, Apr 26, 2021 at 12:34:21AM +0200, Andreas Rheinhardt wrote:
> When the packet size is known in advance like here, one can avoid
> an intermediate buffer for the packet data.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> ---
>  libavcodec/dvenc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

this seems to break fate here:
not sure why or if i did something wrong

TEST    vsynth1-dv-hd
--- ./tests/ref/vsynth/vsynth1-dv-hd	2021-04-25 11:26:39.215771845 +0200
+++ tests/data/fate/vsynth1-dv-hd	2021-04-26 15:02:16.645954326 +0200
@@ -1,4 +1,4 @@
-b2bcafc74dec5f9ca516cb25dd07459b *tests/data/fate/vsynth1-dv-hd.dv
+382fbccaf3b3071895b30d9360f96c11 *tests/data/fate/vsynth1-dv-hd.dv
 14400000 tests/data/fate/vsynth1-dv-hd.dv
 34b78cf725346c7f819c9d6209b8299a *tests/data/fate/vsynth1-dv-hd.out.rawvideo
 stddev:    4.30 PSNR: 35.45 MAXDIFF:   74 bytes:  7603200/  7603200
Test vsynth1-dv-hd failed. Look at tests/data/fate/vsynth1-dv-hd.err for details.
tests/Makefile:255: recipe for target 'fate-vsynth1-dv-hd' failed
make: *** [fate-vsynth1-dv-hd] Error 1

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

"You are 36 times more likely to die in a bathtub than at the hands of a
terrorist. Also, you are 2.5 times more likely to become a president and
2 times more likely to become an astronaut, than to die in a terrorist
attack." -- Thoughty2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210426/38ec3660/attachment.sig>


More information about the ffmpeg-devel mailing list