[FFmpeg-devel] [PATCH v4 2/3] avformat/westwoodaudenc: Adds muxer for Westwood AUD format.

[Zane van Iperen]

On 25/4/21 8:42 am, Aidan Richmond wrote:

> +
> +static int wsaud_init(AVFormatContext *ctx)
> +{
> +    AVStream     *st = ctx->streams[0];
> +    AVIOContext  *pb = ctx->pb;
> +
> +    /* Stream must be seekable to correctly write the file. */
> +    if(!(pb->seekable & AVIO_SEEKABLE_NORMAL)) {

Missing space, "if ("


> +static int wsaud_write_header(AVFormatContext *ctx)
> +{
> +    AVStream     *st = ctx->streams[0];
> +    AVIOContext  *pb = ctx->pb;
> +    AUDMuxContext *a = ctx->priv_data;
> +    int ret;
> +    unsigned char flags = 0;
> +
> +    ret = wsaud_init(ctx);

AVOutputFormat::init should be used for this purpose. See line 312 in libavformat/apm.c
for an example.

The rest lgtm. Will apply after these notes are fixed.

Zane