[FFmpeg-devel] [PATCH] Gsoc: add the two fuzzy targets

Michael Niedermayer michael at niedermayer.cc
Tue Apr 20 14:12:27 EEST 2021


On Tue, Apr 20, 2021 at 12:34:13PM +0800, Heng Zhang wrote:
> 
> 
> > 在 2021年4月19日,下午5:47,Michael Niedermayer <michael at niedermayer.cc> 写道:
> > 
> > On Mon, Apr 19, 2021 at 05:06:10PM +0800, a397341575 at 163.com <mailto:a397341575 at 163.com> wrote:
> >> From: toseven <Byone.heng at gmail.com>
[...]
> >> +    if (ret < 0)
> >> +    {
> >> +        fprintf(stderr, "Error occurred in av_packet_add_side_data: %s\n",
> >> +        av_err2str(ret));
> >> +    }
> >> +    return ret;
> > 
> > the { } placing style mismatches whats used in FFmpeg (i dont mind but some people do mind)
> > 
> > more general, how much code coverage is gained with these 2 fuzzers compared to what already exists ?
> > 
> > thanks
> 
> Okay, I will modify my style to adopt for FFmpeg. What is more, I didn’t compare the code coverage between them. Do I have to do this?  I mainly refer to the fate test from libavcodec/tests/avpacket.c and libavfilter/tests/formats.c.

If code coverage does not improve, what would be the reason for FFmpeg to
include the code ?

Thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210420/e6f33dae/attachment.sig>


More information about the ffmpeg-devel mailing list