[FFmpeg-devel] n4.4 release bug (?) on ffmpeg.c av_fifo_generic_read

[Đông Nguyễn]

Hi,

Not sure this is the correct place to post this, but I've noticed some
recent changes (n.4.4) on ffmpeg.c which seems suspicious to me.

https://github.com/FFmpeg/FFmpeg/blob/n4.4/fftools/ffmpeg.c#L532-L535
https://github.com/FFmpeg/FFmpeg/blob/n4.4/fftools/ffmpeg.c#L614-L616

IIRC, before these changes, av_fifo_generic_read operates on whole struct
of AVFrame and AVPacket, not sole pointer (which has only 8 bytes on 64bit
machine)

After that, calling "free" on those pointers potentially causes malloc heap
crashes.

Please correct me if I'm wrong. Thanks

Dong Nguyen