[FFmpeg-devel] [PATCH 1/1] avcodec/nvenc: move lossless presets after new ones

Timo Rothenpieler timo at rothenpieler.org
Sat Apr 17 20:25:06 EEST 2021


I think I'd much prefer to stop relying on the order of this enum entirely.

nvenc_map_preset already sets a lossless flag. But it's called way too 
late for the capability check.
I see no reason the call to nvenc_map_preset can't be moved to much earlier.
Like, right into ff_nvenc_encode_init. Then the capacility check can 
just check for the NVENC_LOSSLESS flag instead of relying on the order 
of that enum.

I don't believe anything else relies on it, and if it does, it should 
changed to work like the above.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4494 bytes
Desc: S/MIME Cryptographic Signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210417/be47aae8/attachment.bin>


More information about the ffmpeg-devel mailing list