[FFmpeg-devel] [PATCH 6/6] avformat/mvi: Check audio_data_size to be non negative

Michael Niedermayer michael at niedermayer.cc
Sun Apr 11 01:24:46 EEST 2021


Fixes: left shift of negative value -224
Fixes: 32144/clusterfuzz-testcase-minimized-ffmpeg_dem_MVI_fuzzer-4971479323246592

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavformat/mvi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/mvi.c b/libavformat/mvi.c
index cfdbe5d273..10bf24408f 100644
--- a/libavformat/mvi.c
+++ b/libavformat/mvi.c
@@ -73,7 +73,7 @@ static int read_header(AVFormatContext *s)
     avio_rl16(pb);
     avio_r8(pb);
 
-    if (frames_count == 0 || mvi->audio_data_size == 0)
+    if (frames_count == 0 || (int)mvi->audio_data_size <= 0)
         return AVERROR_INVALIDDATA;
 
     if (version != 7 || player_version > 213) {
-- 
2.17.1



More information about the ffmpeg-devel mailing list