[FFmpeg-devel] [PATCH 1/3] avformat/movenc: Free old vos_data before overwriting it

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Mon Sep 28 20:36:40 EEST 2020


Otherwise the old data leaks whenever extradata needs to be rewritten
(e.g. when encoding FLAC with our encoder that sends an updated
extradata packet at the end).

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
---
 libavformat/movenc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index a90bbfa458..c53be74a64 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -6978,6 +6978,7 @@ static int mov_write_trailer(AVFormatContext *s)
             AVCodecParameters *par = track->par;
 
             track->vos_len  = par->extradata_size;
+            av_freep(&track->vos_data);
             track->vos_data = av_malloc(track->vos_len + AV_INPUT_BUFFER_PADDING_SIZE);
             if (!track->vos_data)
                 return AVERROR(ENOMEM);
-- 
2.25.1



More information about the ffmpeg-devel mailing list