[FFmpeg-devel] [PATCH] avformat/aviobuf: fix broken logic in ffio_ensure_seekback()

Michael Niedermayer michael at niedermayer.cc
Sat Sep 26 13:37:23 EEST 2020


On Sun, Sep 20, 2020 at 10:49:12AM +0200, Marton Balint wrote:
[...]

> fundamental problem is that ffio_ensure_seekback simply cannot be
> implemented efficiently with the current design. The guarantees should be
> reduced (e.g. ffio_ensure_seekback can flush the buffer and invalidate
> previous ffio_ensure_seekback request)

this probably makes sense, would this cause a problem to any code using it ?

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200926/5d3983b3/attachment.sig>


More information about the ffmpeg-devel mailing list