[FFmpeg-devel] [PATCH 20/25] avcodec/utils: Improve check for freeing codec private options

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Sat Sep 26 13:27:59 EEST 2020


Don't check for AVCodec.priv_data_size (which is always true if
AVCodec.priv_class is set). Instead check for AVCodecContext.priv_data
to actually exist.

(Note: av_opt_free(NULL) is a no-op.)

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
---
 libavcodec/utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/utils.c b/libavcodec/utils.c
index 8e7c3125aa..a8af45d0c3 100644
--- a/libavcodec/utils.c
+++ b/libavcodec/utils.c
@@ -1030,7 +1030,7 @@ free_and_end:
     if (HAVE_THREADS && avci->thread_ctx)
         ff_thread_free(avctx);
 
-    if (codec->priv_class && codec->priv_data_size)
+    if (codec->priv_class && avctx->priv_data)
         av_opt_free(avctx->priv_data);
     av_opt_free(avctx);
 
-- 
2.25.1



More information about the ffmpeg-devel mailing list