[FFmpeg-devel] [PATCH] tests/fate-run: Always overwrite output files for md5 tests

Jan Ekström jeebjp at gmail.com
Wed Sep 23 16:49:58 EEST 2020


On Sun, Sep 20, 2020 at 5:54 PM Andreas Rheinhardt
<andreas.rheinhardt at gmail.com> wrote:
>
> Otherwise the result of such tests will not accurately reflect the
> current state.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---
>  tests/fate-run.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/fate-run.sh b/tests/fate-run.sh
> index 1b283e9c35..58d5fdbb60 100755
> --- a/tests/fate-run.sh
> +++ b/tests/fate-run.sh
> @@ -158,7 +158,7 @@ md5pipe(){
>  md5(){
>      encfile="${outdir}/${test}.out"
>      cleanfiles="$cleanfiles $encfile"
> -    ffmpeg "$@" $(target_path $encfile)
> +    ffmpeg -y "$@" $(target_path $encfile)
>      do_md5sum $encfile | awk '{print $1}'
>  }
>
> --
> 2.25.1

LGTM.

I think I hit this when working with the movenc changes recently when
I had to update fate-mov-gpmf-remux.

In theory these tests should be using stdout + file redirection, but
alas this is what's configured here at the moment :) .

Jan


More information about the ffmpeg-devel mailing list