[FFmpeg-devel] [PATCH 10/21] avformat/dashdec: Fix memleaks upon read_header failure

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Sat Sep 19 19:35:59 EEST 2020


Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
---
Making sure that it's safe to call this demuxer's read_close function
upon read_header failure was of course the initial rationale behind this
patchset.

 libavformat/dashdec.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index 4f87ef981b..311a19e425 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.c
@@ -2047,6 +2047,7 @@ static int copy_init_section(struct representation *rep_dest, struct representat
     return 0;
 }
 
+static int dash_close(AVFormatContext *s);
 
 static int dash_read_header(AVFormatContext *s)
 {
@@ -2178,6 +2179,7 @@ static int dash_read_header(AVFormatContext *s)
 
     return 0;
 fail:
+    dash_close(s);
     return ret;
 }
 
-- 
2.25.1



More information about the ffmpeg-devel mailing list