[FFmpeg-devel] [PATCH v3 2/2] dnn_backend_native_layer_conv2d.c: refine code.

[Xu Jun]

----- Original Message -----
> From: "Yejun Guo" <yejun.guo at intel.com>
> To: "FFmpeg development discussions and patches" <ffmpeg-devel at ffmpeg.org>
> Cc: "xujunzz" <xujunzz at sjtu.edu.cn>
> Sent: Thursday, September 17, 2020 9:30:08 PM
> Subject: RE: [FFmpeg-devel] [PATCH v3 2/2] dnn_backend_native_layer_conv2d.c: refine code.

>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Hendrik
>> Leppkes
>> Sent: 2020年9月17日 20:28
>> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
>> Subject: Re: [FFmpeg-devel] [PATCH v3 2/2]
>> dnn_backend_native_layer_conv2d.c: refine code.
>> 
>> On Thu, Sep 17, 2020 at 2:02 PM Guo, Yejun <yejun.guo at intel.com> wrote:
>> >
>> >
>> >
>> > > -----Original Message-----
>> > > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
>> > > Hendrik Leppkes
>> > > Sent: 2020年9月17日 19:21
>> > > To: FFmpeg development discussions and patches
>> > > <ffmpeg-devel at ffmpeg.org>
>> > > Subject: Re: [FFmpeg-devel] [PATCH v3 2/2]
>> > > dnn_backend_native_layer_conv2d.c: refine code.
>> > >
>> > > On Thu, Sep 17, 2020 at 4:07 AM Guo, Yejun <yejun.guo at intel.com> wrote:
>> > > >
>> > > >
>> > > >
>> > > > > -----Original Message-----
>> > > > > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf
>> > > > > Of xujunzz at sjtu.edu.cn
>> > > > > Sent: 2020年9月16日 18:07
>> > > > > To: ffmpeg-devel at ffmpeg.org
>> > > > > Cc: xujunzz at sjtu.edu.cn
>> > > > > Subject: [FFmpeg-devel] [PATCH v3 2/2]
>> > > dnn_backend_native_layer_conv2d.c:
>> > > > > refine code.
>> > > > >
>> > > > > From: Xu Jun <xujunzz at sjtu.edu.cn>
>> > > > >
>> > > > > Move thread area allocate out of thread function into main thread.
>> > > > >
>> > > > > Signed-off-by: Xu Jun <xujunzz at sjtu.edu.cn>
>> > > > > ---
>> > > > >  .../dnn/dnn_backend_native_layer_conv2d.c     | 30
>> +++++++++----------
>> > > > >  1 file changed, 14 insertions(+), 16 deletions(-)
>> > > >
>> > > > LGTM, will push soon, thanks.
>> > >
>> > > The dnn-layer-conv2d test fails after the recent changes on some
>> > > systems,
>> > > namely:
>> > >
>> > > Windows mingw 64-bit (eg.
>> > > http://fate.ffmpeg.org/report.cgi?time=20200917051623&slot=x86_64-mi
>> > > ngw-
>> > > w64-windows-native)
>> > > MSVC 32-bit static build (eg.
>> > > http://fate.ffmpeg.org/report.cgi?time=20200917102627&slot=x86_32-ms
>> > > vc16
>> > > -windows-native)
>> > > and maybe more windows combination, some of my boxes are still running
>> FATE.
>> > >
>> > > There is no output, just a wrong return value apparently. Any ideas/fixes?
>> > >
>> > thanks for pointing out.
>> >
>> > I think the output is in file dnn-layer-conv2d.err "Test
>> > dnn-layer-conv2d failed. Look at tests/data/fate/dnn-layer-conv2d.err for
>> details."
>> >
>> 
>> There is no output, all these files are empty.
>> 
> I see, and we are setting up the system locally to reproduce the issue.

I have build my mingw win10 environment and have reproduce the issue. 
I'm going to look for the bug and try to fix it.

- Xu Jun