[FFmpeg-devel] [PATCH 8/9] avfilter/vf_subtitles: Return early upon avformat_open_input() failure

Nicolas George george at nsup.org
Fri Sep 11 13:38:58 EEST 2020


Andreas Rheinhardt (12020-09-11):
> It avoids cleaning up three inexistent objects; I actually regarded this
> as enough benefit to merit the change.

Cleaning-up inexistent objects is a negligible cost. In this case, it
happens in a part of the code that is particularly not speed-critical. I
think the robustness of the code takes precedence here.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200911/501681f0/attachment.sig>


More information about the ffmpeg-devel mailing list