[FFmpeg-devel] [PATCH 3/3] avfilter/formats: Remove pointless checks

Nicolas George george at nsup.org
Fri Sep 11 12:25:32 EEST 2020


Andreas Rheinhardt (12020-09-11):
> ff_formats_ref() takes a pointer to an AVFilterFormats and a pointer to
> a pointer to an AVFilterFormats as arguments and adds the latter as an
> owner to the list pointed to by the former; the latter is hereby always
> the address of a list contained in an AVFilterFormatsConfig and can
> therefore not be NULL. So remove the check for whether it is NULL; also
> do the same for ff_channel_layouts_ref().
> 
> Also do the same for the unref functions where argument is never NULL
> because it is always the address of an existing lvalue.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---
>  libavfilter/formats.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

LGTM.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200911/dc1bd0fe/attachment.sig>


More information about the ffmpeg-devel mailing list