[FFmpeg-devel] [PATCH 1/3] avfilter/formats: Don't typedef structure a second time

[Nicolas George]

Andreas Rheinhardt (12020-09-11):
> Before commit 2f76476549a01ae2c4ec2a440e4b14c5aba64869, avfilter.h
> contained no typedef for AVFilterChannelLayouts; all references to it
> were done using its struct tag. formats.h meanwhile contained the
> definition of the struct and a typedef for it. Said commit now added a
> typedef in avfilter.h, too, bringing it in line with AVFilterFormats;
> yet this means that there are two typedefs for AVFilterChannelLayouts
> (in contrast to AVFilterFormats which is only typedef'ed in avfilter.h).
> 
> The problem is that older versions of GCC don't like this and error out:
> http://fate.ffmpeg.org/history.cgi?slot=x86_64-openbsd5.6-gcc4.2-conf2
> is one of the FATE boxes that now fail to compile. So just remove the
> typedef in formats.h.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---
>  libavfilter/formats.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

LGTM, thanks.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200911/ccba9f55/attachment.sig>