[FFmpeg-devel] [PATCH 5/9] avfilter/vf_subtitles: Fix leaks on failure

Nicolas George george at nsup.org
Fri Sep 11 12:19:56 EEST 2020


Andreas Rheinhardt (12020-09-10):
> init_subtitles() sometimes returned directly upon error without cleaning
> up after itself. The easiest way to trigger this is by using
> picture-based subtitles; it is also possible to run into this in case of
> missing decoders or allocation failures.
> 
> Furthermore, return the proper error code in case of missing decoder.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---
>  libavfilter/vf_subtitles.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)

LGTM.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200911/6aad4bbe/attachment.sig>


More information about the ffmpeg-devel mailing list