[FFmpeg-devel] [PATCH 2/2] Fix msa can't be disabled when '--cpu=loongson3a' assigned.

[Michael Niedermayer]

On Thu, Sep 10, 2020 at 07:05:38PM +0800, Shiyou Yin wrote:
> >-----Original Message-----
> >From: ffmpeg-devel-bounces at ffmpeg.org [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf Of
> >Shiyou Yin
> >Sent: Thursday, September 3, 2020 2:30 PM
> >To: ffmpeg-devel at ffmpeg.org
> >Subject: [FFmpeg-devel] [PATCH 2/2] Fix msa can't be disabled when '--cpu=loongson3a' assigned.
> >
> >There are compiler and runtime check for MSA and MMI.
> >Remove the redundant setting of MSA and MMI for cores specified by "--cpu".
> >
> >Signed-off-by: Shiyou Yin <yinshiyou-hf at loongson.cn>
> >---
> > configure | 9 ---------
> > 1 file changed, 9 deletions(-)
> >
> >diff --git a/configure b/configure
> >index 5640720..7f103fa 100755
> >--- a/configure
> >+++ b/configure
> >@@ -5025,8 +5025,6 @@ elif enabled mips; then
> >         disable loongson3
> >         disable mipsdsp
> >         disable mipsdspr2
> >-        disable msa
> >-        disable mmi
> >
> >         cpuflags="-march=$cpu"
> >
> >@@ -5035,17 +5033,13 @@ elif enabled mips; then
> >             mips1|mips3)
> >             ;;
> >             mips32r2)
> >-                enable msa
> >                 enable mips32r2
> >             ;;
> >             mips32r5)
> >-                enable msa
> >                 enable mips32r2
> >                 enable mips32r5
> >             ;;
> >             mips64r2|mips64r5)
> >-                enable msa
> >-                enable mmi
> >                 enable mips64r2
> >                 enable loongson3
> >             ;;
> >@@ -5062,7 +5056,6 @@ elif enabled mips; then
> >                 enable mips32r2
> >             ;;
> >             p5600)
> >-                enable msa
> >                 enable mips32r2
> >                 enable mips32r5
> >                 check_cflags "-mtune=p5600" && check_cflags "-msched-weight -mload-store-pairs
> >-funroll-loops"
> >@@ -5077,7 +5070,6 @@ elif enabled mips; then
> >             ;;
> >             # Cores from Loongson
> >             loongson2e|loongson2f|loongson3*)
> >-                enable mmi
> >                 enable local_aligned
> >                 enable simd_align_16
> >                 enable fast_64bit
> >@@ -5100,7 +5092,6 @@ elif enabled mips; then
> >                 case $cpu in
> >                     loongson3*)
> >                         enable loongson3
> >-                        enable msa
> >                         cpuflags="-march=loongson3a -mhard-float $expensive_optimization_flag"
> >                     ;;
> >                     loongson2e)
> >--
> >2.1.0
> >
> 
> Ping.

will apply

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200910/0daf9caf/attachment.sig>