[FFmpeg-devel] [PATCH 1/3] avcodec/fastaudio: Check channels

[Michael Niedermayer]

On Wed, Sep 09, 2020 at 03:00:51AM +0200, Paul B Mahol wrote:
> On Tue, Sep 08, 2020 at 11:29:19PM +0200, Michael Niedermayer wrote:
> > Fixes: division by 0
> > Fixes: 25419/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FASTAUDIO_fuzzer-5632544761184256
> > Fixes: 25433/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FASTAUDIO_fuzzer-6215671900536832
> > 
> > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavcodec/fastaudio.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> 
> This should be in generic path somehow. There are decoders that does not need this check
> as they store number of channels in bitstream, but there are others that do not, and thus adding
> this check for each and every one of them is not nice.

Posted a implementation using a different, generic approuch
but such generic approuch requires all decoders to declare correctly
if they store the channel configuration in some header. I suspect not all
codecs have this correct yet after the patchset.
maybe you can check if your decoders set the flag correctly
fate and a bunch of files i have all pass but i do not have input files
for all decoders ...

Thanks


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200910/e4957934/attachment.sig>