[FFmpeg-devel] [PATCH 02/15] lavc/codec_desc: add additional JPEG and BMP MIME types

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Wed Sep 9 16:28:05 EEST 2020


Oneric:
> On Wed, Sep 09, 2020 at 01:02:04 -0500, rcombs wrote:
>> ---
>>  libavcodec/codec_desc.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c
>> index 3dee640360..49a00ad264 100644
>> --- a/libavcodec/codec_desc.c
>> +++ b/libavcodec/codec_desc.c
>> @@ -82,7 +82,7 @@ static const AVCodecDescriptor codec_descriptors[] = {
>>          .name      = "mjpeg",
>>          .long_name = NULL_IF_CONFIG_SMALL("Motion JPEG"),
>>          .props     = AV_CODEC_PROP_INTRA_ONLY | AV_CODEC_PROP_LOSSY,
>> -        .mime_types= MT("image/jpeg"),
>> +        .mime_types= MT("image/jpeg", "image/jpg"),
> 
> "image/jpg" doesn't seeem to be an official IANA MIME type ("image/jpeg" is).
> That ofc doesn't mean it isn't being used, but after a quick search I can't 
> find a reference for "image/jpg" anywhere.
> Did you encounter a program using "image/jpg"? If not it may be better to 
> stick with "image/jpeg" only.
> 
The ff_id3v2_mime_tags array (removed in patch 14 of this series)
contains this. It has been added intentionally in
f704eb612b3333a589d83741e07bfbdf1cffb8cb, yet without giving any reason
for it.

- Andreas


More information about the ffmpeg-devel mailing list