[FFmpeg-devel] [PATCH] lavfi/buffersink: cast to uint64_t before shifting.

[James Almer]

On 9/8/2020 3:19 PM, Nicolas George wrote:
> Andreas Rheinhardt (12020-09-08):
>> Using ULL would be shorter.
> 
> But it would be wrong, it could be more than 64 bits. For modern C,
> using longs and shorts directly is a mistake (or the consequence of
> dealing with an obsolescent library), these types are used internally to
> implement the sane types from stdint.h. I know we use ULL like this all
> over the place, but I will not use it in my code.

You should use the stdint.h UINT64_C macro then, instead of casting.

> 
> Regards,
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>