[FFmpeg-devel] [PATCH] lavf/formats: more logical testing of inputs and outputs.

[Nicolas George]

Andreas Rheinhardt (12020-08-23):
> IIRC lavf = libavformat, lavfi = libavfilter. But I might be wrong.

Fixed and pushed.

> The change itself is ok; I wondered whether I should send a patch for
> this, but I dislike patches designed to make an analyzer happy. But
> given that it is possible for ctx->inputs to be different from NULL even
> if ctx->nb_inputs is zero (namely if ctx->inputs =
> av_malloc_array(ctx->nb_inputs, sizeof...) has been used) the new check
> is more correct and not only for Coverity.
> Notice that these issues are actually not new: They are the same as
> 1452428 and 1452429 and 242ba4d74cc95aa78528e4496de7cc63816a877b just
> made Coverity detect this as new issues.

I agree with you. I would not have made the change if it was just to
make Coverity happy, but in this instance it was right: these tests were
misleading, remnants of early hours of lavfi when we considered things
that were abandoned later.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200908/72db8fd3/attachment.sig>