[FFmpeg-devel] [PATCH v2] cbs_av1: Fill tile width/height values when uniform_tile_spacing_flag is set

Mark Thompson sw at jkqxz.net
Wed Sep 2 02:13:15 EEST 2020


On 01/09/2020 08:16, Wang, Fei W wrote:
> 
> 
>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Mark
>> Thompson
>> Sent: Tuesday, September 1, 2020 5:01 AM
>> To: ffmpeg-devel at ffmpeg.org
>> Subject: [FFmpeg-devel] [PATCH v2] cbs_av1: Fill tile width/height values when
>> uniform_tile_spacing_flag is set
>>
>> They are not explicitly in the bitstream in this case, but it is helpful to be able to
>> use these values without always needing to check the flag beforehand.
>> ---
>> ...
>>
>>    libavcodec/cbs_av1_syntax_template.c | 9 +++++++++
>>    1 file changed, 9 insertions(+)
>>
>> diff --git a/libavcodec/cbs_av1_syntax_template.c
>> b/libavcodec/cbs_av1_syntax_template.c
>> index 19b82bc3f8..2d2e240e3e 100644
>> --- a/libavcodec/cbs_av1_syntax_template.c
>> +++ b/libavcodec/cbs_av1_syntax_template.c
>> @@ -636,6 +636,15 @@ static int FUNC(tile_info)(CodedBitstreamContext *ctx,
>> RWContext *rw,
>>                current->tile_rows_log2;
>>            current->tile_rows = (sb_rows + tile_height_sb - 1) / tile_height_sb;
>>
>> +        for (i = 0; i < current->tile_cols - 1; i++)
>> +            infer(width_in_sbs_minus_1[i], tile_width_sb - 1);
>> +        infer(width_in_sbs_minus_1[i],
>> +              sb_cols - (current->tile_cols - 1) * tile_width_sb - 1);
>> +        for (i = 0; i < current->tile_rows - 1; i++)
>> +            infer(height_in_sbs_minus_1[i], tile_height_sb - 1);
>> +        infer(height_in_sbs_minus_1[i],
>> +              sb_rows - (current->tile_rows - 1) * tile_height_sb - 1);
>> +
> LGTM, could you help to merge this patch? I will submit 2nd version of VAAPI AV1
> decoder patch base on this change. Thanks.

Applied - thank you for the review!

- Mark


More information about the ffmpeg-devel mailing list