[FFmpeg-devel] [PATCH] avformat: add mca demuxer

[liushuyu at aosc.io]

On 2020-09-01 17:07, Carl Eugen Hoyos wrote:
> Am Mi., 2. Sept. 2020 um 00:58 Uhr schrieb <liushuyu at aosc.io>:
> 
>> +static int probe(const AVProbeData *p)
>> +{
>> +    if (AV_RL32(p->buf) == MKTAG('M', 'A', 'D', 'P') &&
>> +        (AV_RL16(p->buf + 4) > 0x00 || AV_RL16(p->buf + 4) <= 0xff))
>> +        return AVPROBE_SCORE_MAX / 3 * 2;
>> +    return 0;
> 
> At least add the version check from read_header(),
> you could also add the "sanity checks" you do
> there to this function.
> 
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".

Thanks for the extremely quick response! I agree I can probably move the 
version check to `probe()`.

However the other checks require reading far into the header, I don't 
know if it's appropriate to do that in `probe()`.

Thanks,
Zixing