[FFmpeg-devel] [PATCH 2/4] avformat/concatdec: Check filename length before use

[Andreas Rheinhardt]

Nicolas George:
> Michael Niedermayer (12020-10-28):
>> Fixes: out array read
>> Fixes: 26610/clusterfuzz-testcase-minimized-ffmpeg_dem_CONCAT_fuzzer-5631838049271808
>>
>> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
>> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
>> ---
>>  libavformat/concatdec.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> This is not the first time such a fix is proposed. If strcmp() does not
> behave intelligently, then we need an extra function for the task, but
> duplicating the test all over the place is not a good idea.
> 
We already have av_strstart() which would also allow us to avoid
computing strlen(proto) at all.

- Andreas