[FFmpeg-devel] [PATCH 1/2] avcodec/hevcdec: fix stat_coeff save/load for persistent_rice_adaptation_enabled_flag

[Christophe Gisquet]

Le mer. 9 sept. 2020 à 07:51, Guangxin Xu <oddstone at gmail.com> a écrit :
> Hi Mickaël & all,
> any suggestions?

The patch is almost good, though I would have hoped to link at a
relevant part of the specs and TableStatCoeff* beyong just "9.3".

Though as I suspected, there is probably something missing. Maybe
around sync across (tile) threads?

You can check for yourself by running it like:
make fate-hevc-conformance-WPP_HIGH_TP_444_8BIT_RExt_Apple_2
THREADS=12 THREAD_TYPE=slice

Sure enough, the MD5 becomes random:
-0,          0,          0,        1,  1179648, 0x78e55a69
-0,          1,          1,        1,  1179648, 0x5babb3cb
-0,          2,          2,        1,  1179648, 0x65935648
+0,          0,          0,        1,  1179648, 0xa9a4a727
+0,          1,          1,        1,  1179648, 0xf4bfd32d
+0,          2,          2,        1,  1179648, 0x4f28807a