[FFmpeg-devel] [PATCH v3 5/6] ffmpeg: move field order decision making to encoder initialization

[Jan Ekström]

On Tue, Oct 27, 2020, 13:13 Anton Khirnov <anton at khirnov.net> wrote:
>
> Quoting Jan Ekström (2020-10-16 15:16:48)
> > We now have the possibility of getting AVFrames here, and we should
> > not touch the muxer's codecpar after writing the header.
> > ---
> >  fftools/ffmpeg.c                              | 27 ++++++++++---------
> >  .../fate/concat-demuxer-extended-lavf-mxf_d10 |  2 +-
> >  .../fate/concat-demuxer-simple1-lavf-mxf_d10  |  2 +-
> >  tests/ref/fate/rgb24-mkv                      |  4 +--
> >  tests/ref/lavf/mxf_d10                        |  2 +-
> >  5 files changed, 19 insertions(+), 18 deletions(-)
>
> Why do the tests change?

1. Matroska and mxf write interlaced/progressive field
2. Before the codecpar was prodded after init/write_header was
executed for muxer.
3. Now the codecpar is properly prodded before init/write_header is
executed for muxer and the encoder itself is initialized.

So basically I verified that all the changes seemed to make sense.
Will add a remark about it to the commit message This logic already
existed, and now it is just done at the proper spot.

Jan