[FFmpeg-devel] [PATCH 9/9] avformat/vividas: better check of current_sb_entry

Michael Niedermayer michael at niedermayer.cc
Thu Oct 22 01:37:33 EEST 2020


This is the simplest fix for the problem, it is possible to instead check
this when the variables are set and propagate errors and then fail earlier

Fixes: out of array access
Fixes: 26490/clusterfuzz-testcase-minimized-ffmpeg_dem_VIVIDAS_fuzzer-5723367078100992

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavformat/vividas.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/libavformat/vividas.c b/libavformat/vividas.c
index 6e93d96aef..83d0ed1167 100644
--- a/libavformat/vividas.c
+++ b/libavformat/vividas.c
@@ -673,6 +673,10 @@ static int viv_read_packet(AVFormatContext *s,
     if (!pb)
         return AVERROR(EIO);
     off = avio_tell(pb);
+
+    if (viv->current_sb_entry >= viv->n_sb_entries)
+        return AVERROR_INVALIDDATA;
+
     off += viv->sb_entries[viv->current_sb_entry].size;
 
     if (viv->sb_entries[viv->current_sb_entry].flag == 0) {
-- 
2.17.1



More information about the ffmpeg-devel mailing list