[FFmpeg-devel] [PATCH] libavformat/hls: add support for SAMPLE-AES decryption in HLS demuxer

[Nachiket Tarate]

_______________________________________
From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> on behalf of Michael Niedermayer <michael at niedermayer.cc>
Sent: Thursday, October 15, 2020 11:35 PM
To: FFmpeg development discussions and patches
Subject: Re: [FFmpeg-devel] [PATCH] libavformat/hls: add support for SAMPLE-AES decryption in HLS demuxer

On Thu, Oct 15, 2020 at 10:15:13PM +0530, Nachiket Tarate wrote:
> Apple HTTP Live Streaming Sample Encryption:
>
> https://developer.apple.com/library/ios/documentation/AudioVideo/Conceptual/HLS_Sample_Encryption
>
> Signed-off-by: Nachiket Tarate <nachiket.tarate at outlook.com>
> ---
>  libavformat/Makefile         |   2 +-
>  libavformat/hls.c            |  93 ++++++-
>  libavformat/hls_sample_aes.c | 497 +++++++++++++++++++++++++++++++++++
>  libavformat/hls_sample_aes.h |  64 +++++
>  libavformat/mpegts.c         |  15 ++
>  5 files changed, 657 insertions(+), 14 deletions(-)
>  create mode 100644 libavformat/hls_sample_aes.c
>  create mode 100644 libavformat/hls_sample_aes.h

This seems to break fate (segfault)
I guess patchwork will notice it too but as i already tested and noticed ...

--- ./tests/ref/fate/segment-mp4-to-ts  2020-10-10 18:08:06.500253003 +0200
+++ tests/data/fate/segment-mp4-to-ts   2020-10-15 20:03:24.586303460 +0200
@@ -128,5 +128,3 @@
 0,     428400,     435600,     3600,      156, 0xd2c3406c, F=0x0, S=1,        1, 0x00e000e0
 0,     432000,     439200,     3600,      330, 0x150d9b60, F=0x0, S=1,        1, 0x00e000e0
 0,     435600,     446400,     3600,      324, 0x558194ee, F=0x0, S=1,        1, 0x00e000e0
-0,     439200,     442800,     3600,      191, 0x108e54d1, F=0x0, S=1,        1, 0x00e000e0
-0,     442800,     450000,     3600,      233, 0xac5b6486, F=0x0
Test segment-mp4-to-ts failed. Look at tests/data/fate/segment-mp4-to-ts.err for details.
tests/Makefile:255: recipe for target 'fate-segment-mp4-to-ts' failed
make: *** [fate-segment-mp4-to-ts] Error 139


I ran FATE with samples again but I didn't get segfault. Can you please help me to reproduce it ?

--
Best Regards,
Nachiket Tarate