[FFmpeg-devel] [PATCH] Unbreak av_malloc_max(0) API/ABI

Joakim Tjernlund Joakim.Tjernlund at infinera.com
Tue Oct 13 20:05:33 EEST 2020


On Tue, 2020-10-13 at 15:24 +0100, Derek Buitenhuis wrote:
> 
> On 13/10/2020 15:19, Joakim Tjernlund wrote:
> > For now just fixing av_malloc_max(0) will do, av_max_malloc2() etc. is beyond this patch.
> 
> As Ronald mentioned, if you're going to fix the ABI/API, you should actually
> fix every use of that ABI/API, not just the one you care about (0).
> 
> So max values of 1-31 should also be handled.

OK, how far do you want to take this, will this do?
    if (max < 32)
        max = INT_MAX;

Complete API fix would need to revert the patch that caused the break to begin with and I don't think you want that ?

 Jocke




More information about the ffmpeg-devel mailing list