[FFmpeg-devel] [PATCH 2/3] avcodec/mpeg12: Don't pretend reading dct_dc_size_* VLCs can fail

[Michael Niedermayer]

On Thu, Oct 08, 2020 at 09:53:12PM +0200, Andreas Rheinhardt wrote:
> It can't because the corresponding trees don't have any loose ends.
> 
> Removing the checks also removed an instance of av_log(NULL (with a
> nonsense message) from the codebase.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---
>  libavcodec/mdec.c      | 2 --
>  libavcodec/mpeg12.h    | 4 ----
>  libavcodec/mpeg12dec.c | 4 ----
>  3 files changed, 10 deletions(-)

It is possible to encode nonsensical dc differnces, these could be checked
for and trigger errors. Not in the current codebase no, but one could add
a check for it
Without such checks, your patch is probably ok

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20201009/f4e6d36c/attachment.sig>