[FFmpeg-devel] [PATCH] libavformat/dashdec: Fix issue with dash on Windows

Christopher Degawa ccom at randomderp.com
Thu Oct 8 16:48:30 EEST 2020


> You should also reset c->adaptionset_lang to NULL after freeing it. (I
> remember finding this issue myself, but somehow forgot to fix it. Strange.)

Ah, I forgot that's what av_freep does in addition to freeing, do you
wish to make the change, or do you want me to?

> (Actually, the lifetime of adaptionset_lang does not extend beyond
> parse_manifest_adaptationset(), so one could even use a local variable
> for it.)

I do also see it being used in parse_manifest_representation, so that
would be one more place you would need to make sure to pass the local
variable, but that would save space on the struct.


More information about the ffmpeg-devel mailing list