[FFmpeg-devel] [PATCH v4 3/9] avformat/s337m: Consider container bit resolution
Tomas Härdin
tjoppen at acc.umu.se
Mon Oct 5 11:32:43 EEST 2020
lör 2020-10-03 klockan 00:23 +0200 skrev Nicolas Gaullier:
> + if (container_word_bits && !(container_word_bits == 16 && word_bits == 16) && !(container_word_bits == 24 && word_bits == 20) && !(container_word_bits == 24 && word_bits == 24))
> + return AVERROR_INVALIDDATA;
>
That if line is overly long. Maybe reformat it a bit like
if (container_word_bits &&
!(container_word_bits == 16 && word_bits == 16) &&
!(container_word_bits == 24 && word_bits == 20) &&
!(container_word_bits == 24 && word_bits == 24)) {
return AVERROR_INVALIDDATA;
}
The rest of the patch looks OK
/Tomas
More information about the ffmpeg-devel
mailing list